This repository was archived by the owner on Sep 21, 2023. It is now read-only.
Fix Jira API request only returning 50 tickets#34
Open
berni2288 wants to merge 1 commit intocoreos:masterfrom
Open
Fix Jira API request only returning 50 tickets#34berni2288 wants to merge 1 commit intocoreos:masterfrom
berni2288 wants to merge 1 commit intocoreos:masterfrom
Conversation
squat
suggested changes
Mar 27, 2019
Contributor
squat
left a comment
squat
left a comment
There was a problem hiding this comment.
Sorry for the long delay here. This patch needs one small change (and one performance improvement) and then it’s good to go.
| @@ -37,15 +37,18 @@ func CompareIssues(config cfg.Config, ghClient clients.GitHubClient, jiraClient | |||
| ids[i] = v.GetID() | |||
Contributor
There was a problem hiding this comment.
Due do this patch, this slice is never used. We should eliminate this loop and then this PR is good.
| for _, ghIssue := range ghIssues { | ||
| found := false | ||
|
|
||
| ids := make([]int, 1) |
Contributor
There was a problem hiding this comment.
We could same some time by allocating this slice only once, before the loop, and then reusing it.
This was referenced Dec 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Ticket #30
One API request per ticket is done now.